Remove units from the ref files #490
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #490 +/- ##
==========================================
- Coverage 96.59% 96.28% -0.32%
==========================================
Files 4 4
Lines 235 242 +7
==========================================
+ Hits 227 233 +6
- Misses 8 9 +1 ☔ View full report in Codecov by Sentry. |
|
Thanks. This looks good. We're currently storing the units as an optional, unused bit of the schema like this: I think that doesn't actually affect RTB's ability to build the files, though, so we could advertise these branches to RTB and they could develop the needed files? |
WilliamJamieson
force-pushed
the
feature/remove_ref_units
branch
2 times, most recently
from
d6b69b0 to
fe6fc3d
Compare
WilliamJamieson
force-pushed
the
feature/remove_ref_units
branch
from
a9a3080 to
871d5d3
Compare
|
This will also address #445 when implemented |
WilliamJamieson
force-pushed
the
feature/remove_ref_units
branch
from
871d5d3 to
d294b26
Compare
WilliamJamieson
force-pushed
the
feature/remove_ref_units
branch
from
d294b26 to
2338fa6
Compare
|
RDM failure will be fixed by spacetelescope/roman_datamodels#408. |
| The V2/V3 coordinates output units after the model is applied. | ||
| tag: tag:stsci.edu:asdf/unit/unit-1.* | ||
| enum: ["arcsec"] | ||
| required: [output_units, input_units] |
There was a problem hiding this comment.
@PaulHuwe Was there a decision to remove input_units`` and output_units`? I think especially the output units can be important.
There was a problem hiding this comment.
You are right that these two should remain.
Resolves RAD-192
Closes #489
This PR removes the units from the reference files.
Tasks
radtests.docs/page.no-changelog-entry-needed.)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types).romancalregression test (https://github.com/spacetelescope/RegressionTests/actions/workflows/romancal.yml) with this branch installed ("git+https://github.com/<fork>/rad@<branch>").roman_datamodelsutilities and tests.News fragment change types:
changes/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.misc.rst: infrastructure or miscellaneous change